[BLAS] Remove queue from host_task_internal API#678
Merged
Rbiessy merged 2 commits intouxlfoundation:developfrom May 20, 2025
Merged
[BLAS] Remove queue from host_task_internal API#678Rbiessy merged 2 commits intouxlfoundation:developfrom
host_task_internal API#678Rbiessy merged 2 commits intouxlfoundation:developfrom
Conversation
A `sycl::queue` object is passed to the `host_task_internal` function as a parameter and used when interacting with a object `CublasScopedContextHandler`. However, the `interop_handle` parameter that is also passed to this entry-point and `CublasScopedContextHandler` constructor is already able to get this information via `interop_handle::get_native_queue()`. This patch removes the superfluous queue parameters and changes the `CublasScopedContextHandler:get_stream()` implementation to use the `interop_handle` method instead. The unused `get_context()` method is also removed.
EwanC
force-pushed
the
remove_cublas_native_queue
branch
from
57004e5 to
6014f17
Compare
rafbiels
suggested changes
May 16, 2025
Contributor
rafbiels
left a comment
rafbiels
left a comment
There was a problem hiding this comment.
Nice, I like this change! Could you do the same for the AdaptiveCpp code path? I can help with testing if needed, let me know.
rafbiels
approved these changes
May 16, 2025
andrewtbarker
approved these changes
May 20, 2025
Contributor
andrewtbarker
left a comment
andrewtbarker
left a comment
There was a problem hiding this comment.
This is a nice simplification, thanks for the changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
sycl::queueobject is passed to thehost_task_internalfunction as a parameter and used when interacting with a objectCublasScopedContextHandler. However, theinterop_handleparameter that is also passed to this entry-point andCublasScopedContextHandlerconstructor is already able to get this information viainterop_handle::get_native_queue().This patch removes the superfluous queue parameters and changes the
CublasScopedContextHandler:get_stream()implementation to use theinterop_handlemethod instead. The unusedget_context()andwait_streammethods are also removed fromCublasScopedContextHandler