Skip to content

Comments

[BLAS] Skip sycl-graph tests on OpenCL and HIP SYCL backends#698

Merged
andrewtbarker merged 1 commit intouxlfoundation:developfrom
EwanC:ewan/skip_sycl-graph_tests_amd
Jul 2, 2025
Merged

[BLAS] Skip sycl-graph tests on OpenCL and HIP SYCL backends#698
andrewtbarker merged 1 commit intouxlfoundation:developfrom
EwanC:ewan/skip_sycl-graph_tests_amd

Conversation

@EwanC
Copy link
Contributor

@EwanC EwanC commented Jul 1, 2025

As reported in #696 (comment) the sycl-graph blas unit_tests are failing on AMD. Skip these tests until the fails can be investigated functionality can be implemented

CI output from https://github.com/uxlfoundation/oneMath/actions/runs/15996062308/job/45125363025?pr=696

Note: Google Test filter = GraphGemmUsmTestSuite/GraphGemmUsmTests.RealSinglePrecision/Column_Major_AMD_EPYC_7763_64_Core_Processor________________
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from GraphGemmUsmTestSuite/GraphGemmUsmTests
[ RUN      ] GraphGemmUsmTestSuite/GraphGemmUsmTests.RealSinglePrecision/Column_Major_AMD_EPYC_7763_64_Core_Processor________________
relative error = nan absolute error = nan limit = 3.57628e-06
Difference in entry (0,0): DPC++ -nan vs. Reference -nan
relative error = nan absolute error = nan limit = 3.57628e-06
Difference in entry (0,1): DPC++ -nan vs. Reference -nan
/home/runner/work/oneMath/oneMath/tests/unit_tests/blas/sycl-graph/gemm_usm.cpp:193: Failure
Expected equality of these values:
  res
    Which is: 0
  1
[  FAILED  ] GraphGemmUsmTestSuite/GraphGemmUsmTests.RealSinglePrecision/Column_Major_AMD_EPYC_7763_64_Core_Processor________________, where GetParam() = (0x1f4ac940, 1-byte object <01>) (247 ms)
[----------] 1 test from GraphGemmUsmTestSuite/GraphGemmUsmTests (247 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (247 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] GraphGemmUsmTestSuite/GraphGemmUsmTests.RealSinglePrecision/Column_Major_AMD_EPYC_7763_64_Core_Processor________________, where GetParam() = (0x1f4ac940, 1-byte object <01>)

 1 FAILED TEST

This is failing on an OpenCL CPU backend, my guess is that in 2025.2 Intel OpenCL CPU implementation started supporting cl_khr_command_buffer which is what enables SYCL-Graph on an OpenCL backend. #669 which added these tests didn't take into account the OpenCL path. Enabling this needs further investigation. I've also disabled testing on the HIP backend until the rocm native-command path takes into account graph recording.

@andrewtbarker andrewtbarker self-requested a review July 1, 2025 17:14
As reported in uxlfoundation#696 (comment)
the sycl-graph blas unit_tests are failing on AMD. Skip these tests
until the functionality can be implemented
@EwanC EwanC force-pushed the ewan/skip_sycl-graph_tests_amd branch from ce8cd35 to 3c4279b Compare July 1, 2025 17:30
@EwanC EwanC marked this pull request as ready for review July 1, 2025 19:02
@EwanC EwanC requested a review from a team as a code owner July 1, 2025 19:02
@EwanC EwanC changed the title [BLAS] Skip sycl-graph tests on AMD [BLAS] Skip sycl-graph tests on OpenCL and HIP SYCL backends Jul 1, 2025
@EwanC
Copy link
Contributor Author

EwanC commented Jul 1, 2025

@andrewtbarker Looks like like this successfully gets the pre-commit CI green. I think only the OpenCL case is needed to fix CI, but I don't think the HIP backend will work either right now so added that too to be conservative.

I'm not working the rest of the week, but I can look into enabling the tests on those backends in more detail when I'm back.

Copy link
Contributor

@andrewtbarker andrewtbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix!

@andrewtbarker andrewtbarker merged commit aba6aca into uxlfoundation:develop Jul 2, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants