[BLAS] Skip sycl-graph tests on OpenCL and HIP SYCL backends#698
Merged
andrewtbarker merged 1 commit intouxlfoundation:developfrom Jul 2, 2025
Merged
Conversation
As reported in uxlfoundation#696 (comment) the sycl-graph blas unit_tests are failing on AMD. Skip these tests until the functionality can be implemented
ce8cd35 to
3c4279b
Compare
Contributor
Author
|
@andrewtbarker Looks like like this successfully gets the pre-commit CI green. I think only the OpenCL case is needed to fix CI, but I don't think the HIP backend will work either right now so added that too to be conservative. I'm not working the rest of the week, but I can look into enabling the tests on those backends in more detail when I'm back. |
andrewtbarker
approved these changes
Jul 1, 2025
Contributor
andrewtbarker
left a comment
There was a problem hiding this comment.
Thank you for the quick fix!
andreyfe1
approved these changes
Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in #696 (comment) the sycl-graph blas unit_tests are failing on AMD. Skip these tests until the fails can be investigated functionality can be implemented
CI output from https://github.com/uxlfoundation/oneMath/actions/runs/15996062308/job/45125363025?pr=696
This is failing on an OpenCL CPU backend, my guess is that in 2025.2 Intel OpenCL CPU implementation started supporting cl_khr_command_buffer which is what enables SYCL-Graph on an OpenCL backend. #669 which added these tests didn't take into account the OpenCL path. Enabling this needs further investigation. I've also disabled testing on the HIP backend until the rocm native-command path takes into account graph recording.