[LAPACK] Allow tests to return Skipped status#700
Merged
sknepper merged 1 commit intouxlfoundation:developfrom Jul 17, 2025
Merged
[LAPACK] Allow tests to return Skipped status#700sknepper merged 1 commit intouxlfoundation:developfrom
sknepper merged 1 commit intouxlfoundation:developfrom
Conversation
andrewtbarker
approved these changes
Jul 17, 2025
Contributor
andrewtbarker
left a comment
andrewtbarker
left a comment
There was a problem hiding this comment.
Thank you for this fix!
sknepper
approved these changes
Jul 17, 2025
Contributor
sknepper
left a comment
sknepper
left a comment
There was a problem hiding this comment.
Thank you for these changes to help improve consistency in the testing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Lapack unimplemented or platform-unsupported tests are reported as successful, behaving differently from other backends where "skipped" status is used.
This adds a skipped status to the lapack test harness so that tests are skipped if they are not actually run
Checklist
All Submissions
They actually don't pass anymore, but that's expected. For example with Armpl LAPACK, all Batch tests are now skipped. this will probably alter test results in most backends, but that's good imo
100% tests passed, 0 tests failed out of 796
Total Test time (real) = 74.55 sec
The following tests did not run:
1993 - LAPACK/RT/GeqrfBatchGroup/GeqrfBatchGroupAccuracyUsm.RealSinglePrecision/cpu_neoverse_v2_0xd4f (Skipped)
1994 - LAPACK/RT/GeqrfBatchGroup/GeqrfBatchGroupAccuracyUsm.RealDoublePrecision/cpu_neoverse_v2_0xd4f (Skipped)
1995 - LAPACK/RT/GeqrfBatchGroup/GeqrfBatchGroupAccuracyUsm.ComplexSinglePrecision/cpu_neoverse_v2_0xd4f (Skipped)
1996 - LAPACK/RT/GeqrfBatchGroup/GeqrfBatchGroupAccuracyUsm.ComplexDoublePrecision/cpu_neoverse_v2_0xd4f (Skipped)
1997 - LAPACK/RT/GeqrfBatchGroup/GeqrfBatchGroupDependencyUsm.RealSinglePrecision/cpu_neoverse_v2_0xd4f (Skipped)
1998 - LAPACK/RT/GeqrfBatchGroup/GeqrfBatchGroupDependencyUsm.RealDoublePrecision/cpu_neoverse_v2_0xd4f (Skipped)
...