[DFT] Add ArmPl DFT backend for aarch64 CPUs#702
Merged
lhuot merged 4 commits intouxlfoundation:developfrom Aug 11, 2025
Merged
[DFT] Add ArmPl DFT backend for aarch64 CPUs#702lhuot merged 4 commits intouxlfoundation:developfrom
lhuot merged 4 commits intouxlfoundation:developfrom
Conversation
lhuot
reviewed
Jul 21, 2025
Contributor
|
Could you please update .github/workflows/pr-arm.yml to include DFT testing with ArmPL backend? |
lhuot
approved these changes
Jul 25, 2025
Contributor
lhuot
left a comment
lhuot
left a comment
There was a problem hiding this comment.
Thank you for adding the ArmPL backend to the DFT domain and enabling testing in the CI! The changes look good to me.
Contributor
|
@dnhsieh-intel could you please help review the PR for onemath-arch-write? |
dnhsieh-intel
approved these changes
Jul 25, 2025
Contributor
dnhsieh-intel
left a comment
dnhsieh-intel
left a comment
There was a problem hiding this comment.
Thanks for the ping! I missed it because of "[DFT]" in the title. I need to update my mental filter...
Anyway, the changes look good to me. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds a DFT backend targeting aarch64 CPUs with ArmPl library.
This is basically a FFTW backend, as ArmPl uses FFTW, and can/will be generalized to other FFTW libraries.
A change has been made to tests to account for backends not supporting scaling during the DFT calls and do the scaling after, as is done in FFTW ( fixes #649 ).
Checklist
All Submissions
1414 passed, 464 skipped,
out_dft_dpcpp.txt