Skip to content

Conversation

adegomme
Copy link
Contributor

Description

This adds a DFT backend targeting aarch64 CPUs with ArmPl library.

This is basically a FFTW backend, as ArmPl uses FFTW, and can/will be generalized to other FFTW libraries.
A change has been made to tests to account for backends not supporting scaling during the DFT calls and do the scaling after, as is done in FFTW ( fixes #649 ).

Checklist

All Submissions

  • [ x] Do all unit tests pass locally? Attach a log.
  • 100% tests passed, 0 tests failed out of 1878
    1414 passed, 464 skipped,
    out_dft_dpcpp.txt

@adegomme adegomme requested review from a team as code owners July 18, 2025 09:54
@lhuot
Copy link
Contributor

lhuot commented Jul 23, 2025

Could you please update .github/workflows/pr-arm.yml to include DFT testing with ArmPL backend?

Copy link
Contributor

@lhuot lhuot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding the ArmPL backend to the DFT domain and enabling testing in the CI! The changes look good to me.

@lhuot
Copy link
Contributor

lhuot commented Jul 25, 2025

@dnhsieh-intel could you please help review the PR for onemath-arch-write?

Copy link
Contributor

@dnhsieh-intel dnhsieh-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping! I missed it because of "[DFT]" in the title. I need to update my mental filter...

Anyway, the changes look good to me. Thank you!

@lhuot lhuot merged commit 846024e into uxlfoundation:develop Aug 11, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DFT: Scaling behaviour
3 participants