[BLAS][SPARSE][DPC++] Add CUDA_TARGETS option to pass for AoT compila… #710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewtbarker
approved these changes
Sep 24, 2025
Comment on lines
+46
to
+63
| if (NOT "${ONEMATH_SYCL_IMPLEMENTATION}" STREQUAL "adaptivecpp") | ||
| target_compile_options(ONEMATH::SYCL::SYCL INTERFACE | ||
| -fsycl-targets=nvptx64-nvidia-cuda -fsycl-unnamed-lambda | ||
| ) | ||
| target_link_options(ONEMATH::SYCL::SYCL INTERFACE | ||
| -fsycl-targets=nvptx64-nvidia-cuda | ||
| ) | ||
|
|
||
| if (DEFINED CUDA_TARGETS AND NOT "${CUDA_TARGETS}" STREQUAL "") | ||
| target_compile_options(ONEMATH::SYCL::SYCL INTERFACE | ||
| -Xsycl-target-backend --cuda-gpu-arch=${CUDA_TARGETS} | ||
| ) | ||
| target_link_options(ONEMATH::SYCL::SYCL INTERFACE | ||
| -Xsycl-target-backend --cuda-gpu-arch=${CUDA_TARGETS} | ||
| ) | ||
| endif() | ||
| endif() | ||
|
|
There was a problem hiding this comment.
this is fine, it is same update as for BLAS, for CUDA + SYCL linking, so no reason to object
Contributor
Author
There was a problem hiding this comment.
Correct, was just adding it for consistency between the domains. Having a way to add AoT support too and to avoid issues with newer CUDA versions
Context: CUDA 13 dropped support for several older NVIDIA GPU architectures, specifically Maxwell (compute capability 5.x), Pascal (compute capability 6.x), and Volta (compute capability 7.0, 7.2) architectures.
spencerpatty
approved these changes
Sep 30, 2025
spencerpatty
left a comment
spencerpatty
left a comment
There was a problem hiding this comment.
approved from Sparse BLAS perspective
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tion
CUDA_TARGETSsimilar to existing option forHIP_TARGETSfor AoT builds of DPC++ compilergenericblasalready has stubs to use arch flags but was not set