Skip to content

Comments

Fix rc file Non-ASCII 8-bit in non-Unicode string#1968

Merged
omalyshe merged 1 commit intouxlfoundation:masterfrom
stephomi:fix-copyright
Feb 16, 2026
Merged

Fix rc file Non-ASCII 8-bit in non-Unicode string#1968
omalyshe merged 1 commit intouxlfoundation:masterfrom
stephomi:fix-copyright

Conversation

@stephomi
Copy link
Contributor

@stephomi stephomi commented Feb 16, 2026

Llvm-mingw on MacOS (when cross-compiling for Windows) refused to build when it happens.

Description

The build error (since commit e8aa5f1) :

llvm-rc: Error in VERSIONINFO statement (ID 1): 
Non-ASCII 8-bit codepoint (169) can't occur in a non-Unicode string

Type of change

Choose one or multiple, leave empty if none of the other choices apply

Add a respective label(s) to PR if you have permissions

  • bug fix - change that fixes an issue
  • new feature - change that adds functionality
  • tests - change in tests
  • infrastructure - change in infrastructure and CI
  • documentation - documentation update

Tests

  • added - required for new features and some bug fixes
  • not needed

Documentation

  • updated in # - add PR number
  • needs to be updated
  • not needed

Breaks backward compatibility

  • Yes
  • No
  • Unknown

Notify the following users

List users with @ to send notifications

Other information

Builds successfully with:
llvm-mingw on macOS (cross-compile)
llvm-mingw on Windows

Llvm-mingw on MacOS refused to build when it happens.
Copy link
Contributor

@omalyshe omalyshe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks you for the fix!

@omalyshe omalyshe merged commit 51dffe9 into uxlfoundation:master Feb 16, 2026
29 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants