Skip to content

Conversation

Alexsandruss
Copy link
Contributor

Description

Separate testing for preview functionality of sklearnex is not required since there is no intersection between regular and preview scopes of sklearnex.


PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.

You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).

Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

N/A

@Alexsandruss Alexsandruss added enhancement New feature or request infra testing Tests for sklearnex/daal4py/onedal4py & patching sklearn labels Jul 1, 2025
@Alexsandruss
Copy link
Contributor Author

/azp run Nightly

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

codecov bot commented Jul 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
azure 78.73% <ø> (-0.98%) ⬇️
github 73.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@icfaust
Copy link
Contributor

icfaust commented Jul 1, 2025

This will complicate the work of daal4py deprecations, for example @richardnorth3 's work here uxlfoundation/oneDAL#3248 and uxlfoundation/oneDAL#3131, and any external contribution on uxlfoundation/oneDAL#3151 . I'm open for counter arguments, but i believe this can be closed until daal4py.sklearn is removed

@icfaust
Copy link
Contributor

icfaust commented Jul 1, 2025

@Alexsandruss let us know how future daal4py deprecations should go with respect to benchmarks and then we can proceed here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request infra testing Tests for sklearnex/daal4py/onedal4py & patching sklearn

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants