DOC, MAINT: Improve GPU docs, remove references to dpctl arrays #2721
Conversation
david-cortes-intel
requested review from
Alexsandruss,
Vika-F,
ethanglaser,
icfaust,
maria-Petrova,
syakov-intel and
yuejiaointel
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 30 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Failing doc CI job appears to be a rate limiting issue with medium.com. |
doc/sources/input-types.rst
Outdated
| will be converted to CSR, which implies more than just data copying. | ||
| - Heterogeneous NumPy array | ||
| - If SYCL queue is provided for device without ``float64`` support but data are ``float64``, data are copied with reduced precision. | ||
| - If SyCL queue is provided for device without ``float64`` support but data are ``float64``, data are copied with reduced precision. |
There was a problem hiding this comment.
Its SYCL in all cases not in code.
| from daal4py.sklearn._utils import sklearn_check_version | ||
| from onedal._config import _get_config as onedal_get_config | ||
|
|
||
| __all__ = ["get_config", "set_config", "config_context"] |
There was a problem hiding this comment.
It defines more objects than these 3. Adding __all__ would avoid making them exportable for asterisk imports.
|
|
||
| __all__ = ["get_config", "set_config", "config_context"] | ||
|
|
||
| tab = " " if (sys.version_info.major == 3 and sys.version_info.minor < 13) else "" |
There was a problem hiding this comment.
Python 3.13 changed how it deals with leading whitespace in docstrings.
There was a problem hiding this comment.
Does that mean we need to do it throughout the repo?
There was a problem hiding this comment.
This same workaround is already used in other places throughout the repository.
2 participants
Description
This PR:
Checklist:
Completeness and readability
Testing