Skip to content

Conversation

@icfaust
Copy link
Contributor

@icfaust icfaust commented Oct 16, 2025

Description

While waiting on CI jobs, abuse PyRight to simplify things. These imports aren't used and can be removed.


Checklist:

Completeness and readability

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with updates and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least a summary table with measured data, if performance change is expected.
  • I have provided justification why performance and/or quality metrics have changed or why changes are not expected.
  • I have extended the benchmarking suite and provided a corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

@david-cortes-intel
Copy link
Contributor

/intelci: run

@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
azure 81.19% <ø> (-0.04%) ⬇️
github 82.81% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
onedal/covariance/incremental_covariance.py 93.47% <ø> (-0.40%) ⬇️
onedal/datatypes/_dlpack.py 69.56% <ø> (-1.27%) ⬇️
onedal/decomposition/incremental_pca.py 96.66% <ø> (-0.11%) ⬇️
onedal/decomposition/pca.py 95.91% <ø> (-0.17%) ⬇️
sklearnex/covariance/incremental_covariance.py 79.41% <ø> (-0.13%) ⬇️
sklearnex/decomposition/pca.py 93.56% <ø> (-0.03%) ⬇️
sklearnex/linear_model/linear.py 83.33% <ø> (-0.12%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@icfaust icfaust marked this pull request as ready for review December 8, 2025 20:35
@icfaust
Copy link
Contributor Author

icfaust commented Dec 8, 2025

/intelci: run

@ethanglaser
Copy link
Contributor

If I remember correctly we explored a tool that handles this - maybe @ahuber21 remembers? I forget if this was integrated or dropped

Copy link
Contributor

@ethanglaser ethanglaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming green CI

@icfaust
Copy link
Contributor Author

icfaust commented Dec 8, 2025

We could add PyRight (which runs aspects of VSCode) #2498, but it would require some time to do and I deprioritized it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants