Skip to content

Work around #76: Don't draw/annotate unless only one finger is used #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Work around #76: Don't draw/annotate unless only one finger is used #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions Pod/Classes/Annotations/PDFAnnotationController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,13 @@ open class PDFAnnotationController: UIViewController {

//MARK: - Touches methods to pass to annotation
open override func touchesBegan(_ touches: Set<UITouch>, with event: UIEvent?) {
guard let touch = touches.first else { return }
// We only allow one-finger touches to start annotations, as otherwise
// when you are pen-editing then try to zoom, one of your fingers will draw instead of zooming
// This is a HACK, as IDEALLY the two-finger pinch would zoom while still in
// annotation editing mode, but for the life of me I could not get that to go, forwarding
// events/touches to pretty much anything.
guard let touch = touches.first, event?.allTouches?.count == 1
else { return }

let page = annotationDelegate?.annotationWillStart(touch: touch)

Expand All @@ -252,14 +258,16 @@ open class PDFAnnotationController: UIViewController {


open override func touchesMoved(_ touches: Set<UITouch>, with event: UIEvent?) {
guard let touch = touches.first else { return }
guard let touch = touches.first, event?.allTouches?.count == 1
else { return }
let point = touch.location(in: pageView)

currentAnnotation?.touchMoved(touch, point: point)
}

open override func touchesEnded(_ touches: Set<UITouch>, with event: UIEvent?) {
guard let touch = touches.first else { return }
guard let touch = touches.first, event?.allTouches?.count == 1
else { return }
let point = touch.location(in: pageView)

currentAnnotation?.touchEnded(touch, point: point)
Expand Down