Open
Conversation
Owner
|
Hi, thanks for PR. I think we should then wait for some multidisk output, maybe somebody else can provide it. I believe it is better to merge universal rather than hardcoded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added 'quick and dirty' support for discovering disks on servers with raid controller that uses cciss linux driver. Exact model of my controller is 'HP Smart Array E200i'. On these servers I have no /dev/sd* , nor /dev/sg* devices. All disk devices are in /dev/cciss directory and look like:
According to man smartctl, smart information should be got using
smartctl -d cciss,Nfrom them where N is disk number. But unfortunately I have no servers with more than one disk with such raid contoller that's why I was able to hardcode only one disk.My suggestion is that the best way to discover all disk is parsing output of
cciss_vol_status /dev/cciss/c0d0 -V(apt-get install cciss-vol-statusin debian) but I can update the code only if I have output of it with more than 1 disk in the system.