Fix Google Play signed APK download with smart checking

[graycreate]

Summary

• Fixed HTTP 204 error by adding alt=media parameter to download requests
• Implemented smart APK availability checking to reduce wait times
• Fixed APK selection logic to properly find universal APKs
• Integrated download job with Play Store upload pipeline

Key Changes

1. Fixed download API calls: Added alt=media parameter to get binary content instead of metadata
2. Smart checking: Check if APK exists before waiting, with periodic polling
3. Improved APK detection: Look for generatedUniversalApk field first, then fallback to base split APKs
4. Pipeline integration: Download job now properly depends on Play Store upload

Test Results

• ✅ Successfully downloads Google Play signed APKs
• ✅ Skips waiting when APK already exists (saves ~5 minutes)
• ✅ Properly handles URL query parameters
• ✅ Downloads complete in 25 seconds when APK is ready

Fixes the download-signed-apk job that was failing with HTTP 204 errors.

[Copilot]

Pull Request Overview

This PR fixes the Google Play signed APK download functionality by resolving HTTP 204 errors and implementing smart availability checking. The changes ensure proper binary content retrieval and reduce unnecessary waiting time during the CI/CD pipeline.

Key changes made:

• Fixed API calls by adding the alt=media parameter to download binary content instead of metadata
• Implemented smart checking logic to verify APK availability before waiting, with periodic polling
• Enhanced APK detection to prioritize universal APKs and fallback to base split APKs with proper targeting

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

The condition expression has redundant ${{ }} wrapper. GitHub Actions automatically evaluates expressions in if conditions, so this should be if: vars.ENABLE_PLAY_STORE_UPLOAD == 'true' && vars.ENABLE_SIGNING == 'true'

Suggested change

	if: ${{ vars.ENABLE_PLAY_STORE_UPLOAD == 'true' && vars.ENABLE_SIGNING == 'true' }}
	if: vars.ENABLE_PLAY_STORE_UPLOAD == 'true' && vars.ENABLE_SIGNING == 'true'

[Copilot]

Direct URI manipulation is fragile and error-prone. Consider using URL parsing libraries like urllib.parse to properly handle query parameters instead of string concatenation.

Suggested change

	# Add alt=media parameter correctly (URL already has query params, so use &)
	if '?' in download_request.uri:
	download_request.uri += '&alt=media'
	else:
	download_request.uri += '?alt=media'
	# Add alt=media parameter correctly using urllib.parse
	from urllib.parse import urlparse, parse_qs, urlencode, urlunparse
	parsed = urlparse(download_request.uri)
	query = parse_qs(parsed.query)
	query['alt'] = ['media']
	new_query = urlencode(query, doseq=True)
	download_request.uri = urlunparse(parsed._replace(query=new_query))

[Copilot]

Import statements should be placed at the top of the script with other imports (lines 414-419) rather than in the middle of the function for better code organization and readability.