Skip to content

fix: resolve TextView font style persistence in RecyclerView (#120) #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: resolve TextView font style persistence in RecyclerView (#120) #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion app/src/main/java/me/ghui/v2er/injector/module/MsgModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,16 @@ protected void convert(ViewHolder holder, NotificationInfo.Reply reply, int posi
holder.getView(R.id.msg_content_tv);
if (!Check.isEmpty(reply.getContent())) {
holder.getView(R.id.msg_content_tv).setVisibility(View.VISIBLE);
// holder.setText(R.id.msg_content_tv, reply.getContent());
// Clear previous text to avoid recycling issues
holder.getTextView(R.id.msg_content_tv).setText("");
holder.getTextView(R.id.msg_content_tv).setMovementMethod(null);
RichText.from(reply.getContent())
.into(holder.getTextView(R.id.msg_content_tv));
} else {
holder.getView(R.id.msg_content_tv).setVisibility(View.GONE);
// Clear text when hiding to avoid recycling issues
holder.getTextView(R.id.msg_content_tv).setText("");
holder.getTextView(R.id.msg_content_tv).setMovementMethod(null);
}
holder.setText(R.id.time_tv, reply.getTime());
}
Expand Down
3 changes: 3 additions & 0 deletions app/src/main/java/me/ghui/v2er/injector/module/SearchModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ protected void convert(ViewHolder holder, SoV2EXSearchResultInfo.Hit hit, int po
holder.setText(R.id.search_result_title_tv, hit.getSource().getTitle());
String footnote = hit.getSource().getCreator() + " 于 " + hit.getSource().getTime() + " 发表, " + hit.getSource().getReplies() + " 回复";
holder.setText(R.id.search_result_footnote_tv, footnote);
// Clear previous text to avoid recycling issues
holder.getTextView(R.id.search_result_content_tv).setText("");
holder.getTextView(R.id.search_result_content_tv).setMovementMethod(null);
RichText.from(hit.getSource().getContent())
.supportUrlClick(false)
.into(holder.getTextView(R.id.search_result_content_tv));
Expand Down
3 changes: 3 additions & 0 deletions app/src/main/java/me/ghui/v2er/injector/module/UserHomeModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,9 @@ public boolean isForViewType(@Nullable UserPageInfo.Item item, int position) {
public void convert(ViewHolder holder, UserPageInfo.Item item, int position) {
UserPageInfo.ReplyItem replyItem = (UserPageInfo.ReplyItem) item;
holder.setText(R.id.reply_title_tv, replyItem.getTitle());
// Clear previous text to avoid recycling issues
holder.getTextView(R.id.reply_content_tv).setText("");
holder.getTextView(R.id.reply_content_tv).setMovementMethod(null);
RichText.from(replyItem.getContent())
.widthDelta(43)
.into(holder.getTextView(R.id.reply_content_tv));
Expand Down
7 changes: 6 additions & 1 deletion app/src/main/java/me/ghui/v2er/module/topic/TopicReplyItemDelegate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,9 @@ public void convert(ViewHolder holder, TopicInfo.Item item, int position) {
contentView.setTextSize(TypedValue.COMPLEX_UNIT_PX, FontSizeUtil.getContentSize());
if (Check.notEmpty(replyInfo.getReplyContent())) {
contentView.setVisibility(View.VISIBLE);
contentView = holder.getView(R.id.content_tv);
// Clear previous text and spans to avoid style persistence
contentView.setText("");
contentView.setMovementMethod(null);
String replyContent = replyInfo.getReplyContent();
OnMemberLinkClickListener clickListener = null;
if (replyContent.contains("/member/")) {
Expand All @@ -87,6 +89,9 @@ public void convert(ViewHolder holder, TopicInfo.Item item, int position) {
.into(contentView);
} else {
contentView.setVisibility(View.GONE);
// Clear text when hiding to avoid recycling issues
contentView.setText("");
contentView.setMovementMethod(null);
}
holder.setText(R.id.floor_tv, replyInfo.getFloor());
}
Expand Down
Loading