fix: implement AppBarTracking to fix navbar scroll behavior on Pixel 10 #167
+33
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make MainActivity implement HackRecyclerView.AppBarTracking interface - Add AppBar offset tracking fields and methods - Update NewsFragment and MsgFragment to set AppBarTracking on their RecyclerViews - Fixes issue where navbar doesn't auto-hide when scrolling on some devices (e.g., Pixel 10) The root cause was that HackRecyclerView's custom nested scroll handling in dispatchNestedPreScroll() relies on AppBarTracking interface to get the AppBar state, but MainActivity wasn't implementing this interface. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR fixes the navbar scroll behavior on devices like Pixel 10 by implementing the AppBarTracking interface in MainActivity. The issue occurred because HackRecyclerView has custom nested scroll handling logic that depends on the AppBarTracking interface to track AppBar state (expanded/idle), which was previously only implemented in UserHomeActivity.
- Implements
HackRecyclerView.AppBarTrackinginterface inMainActivitywith proper AppBar offset tracking - Updates
NewsFragmentandMsgFragmentto use the correctHackRecyclerViewtype and connect to MainActivity's AppBarTracking - Follows the established pattern from
UserHomeActivity
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
MainActivity.java |
Implements AppBarTracking interface, adds offset tracking fields (mAppBarOffset, mAppBarIdle, mAppBarMaxOffset), tracks AppBar offset in onOffsetChanged callback, and implements isAppBarExpanded() and isAppBarIdle() methods |
NewsFragment.java |
Changes mRecyclerView type from LoadMoreRecyclerView to HackRecyclerView (matches XML layout) and adds setAppBarTracking() call to connect with MainActivity's AppBarTracking implementation |
MsgFragment.java |
Changes mRecyclerView type from LoadMoreRecyclerView to HackRecyclerView (matches XML layout) and adds setAppBarTracking() call to connect with MainActivity's AppBarTracking implementation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
HackRecyclerView.AppBarTrackinginterfacemAppBarOffset,mAppBarIdle,mAppBarMaxOffset)setAppBarTracking()on their RecyclerViewsRoot Cause
HackRecyclerView.dispatchNestedPreScroll()has custom nested scroll handling logic to prevent "wobbly" AppBar behavior. This logic depends on theAppBarTrackinginterface to get the current AppBar state (expanded/idle).UserHomeActivitycorrectly implements this interface, butMainActivitywas missing it. This caused the scroll behavior to be unreliable on devices with different scroll physics (like Pixel 10 running Android 15).Test plan
🤖 Generated with Claude Code