Fix build issues by removing unused Condom library #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed unused CondomContext import from App.java - Commented out Condom library dependency due to JitPack connectivity issues - Library was imported but not actually used in the codebase This fixes build failures caused by JitPack being unreachable while maintaining full app functionality. The app already targets Android API level 36, which exceeds Google Play's requirement of API level 35 by August 31, 2025. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Updated MyAppGllideModule to use Registry directly instead of glide.getRegistry() - Added isManifestParsingEnabled() override returning false to prevent manifest parsing conflicts - These changes fix image loading failures introduced by Glide upgrade from 4.11.0 to 4.16.0 The Glide 4.16.0 version introduced breaking changes in how modules register components. This fix ensures proper OkHttp integration with the custom HTTP client configuration. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes build issues by removing the unused Condom library dependency and cleaning up related imports to ensure the app can be built and deployed to Google Play.
- Removed unused CondomContext import from App.java
- Commented out Condom library dependency in build.gradle due to JitPack connectivity issues
- Fixed Glide module implementation and added manifest parsing override
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app/src/main/java/me/ghui/v2er/general/App.java | Removed unused CondomContext import |
| app/build.gradle | Commented out Condom library dependency with explanatory comment |
| app/src/main/java/me/ghui/v2er/general/MyAppGllideModule.java | Added manifest parsing override and fixed registry usage |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| public void registerComponents(Context context, Glide glide, Registry registry) { | ||
| OkHttpUrlLoader.Factory factory = new OkHttpUrlLoader.Factory(APIService.httpClient()); | ||
| glide.getRegistry().replace(GlideUrl.class, InputStream.class, factory); | ||
| registry.replace(GlideUrl.class, InputStream.class, factory); |
There was a problem hiding this comment.
The change from glide.getRegistry().replace() to registry.replace() is correct, but you should verify that the registry parameter is not null before using it, as this could cause a NullPointerException if Glide passes a null registry.
Suggested change
| registry.replace(GlideUrl.class, InputStream.class, factory); | |
| if (registry != null) { | |
| registry.replace(GlideUrl.class, InputStream.class, factory); | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Context
Google Play requires apps to target Android 15 (API level 35) or higher by August 31, 2025. Our app already targets API level 36, but build was failing due to JitPack connectivity issues with the Condom library dependency.
Changes
CondomContextimport fromApp.javaapp/build.gradleTest Plan
Impact
No functional impact - the Condom library was not being used. The app maintains full functionality while fixing the build issues.
🤖 Generated with Claude Code