Skip to content

Conversation

@graycreate
Copy link
Member

Summary

  • Simplify the bundletool keystore creation logic in the download-signed-apk job
  • Remove complex fallback logic that was causing failures with exit code 8

Issue

The download-signed-apk job was failing because of overly complex keystore creation logic with fallback error handling. The keytool command was being redirected to /dev/null making debugging difficult.

Fix

  • Create debug keystore upfront using a simple keytool command
  • Remove the complex try/catch logic with fallback
  • Use consistent keystore filename (debug.keystore)

Test plan

  • Workflow syntax validation
  • Test with v2.3.3 release to verify bundletool works correctly
  • Verify Google Play signed APK is generated and uploaded to release

🤖 Generated with Claude Code

- Remove complex fallback logic that was causing failures
- Create debug keystore upfront before calling bundletool
- Use simpler keytool command without 2>/dev/null redirection

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
Copilot AI review requested due to automatic review settings September 9, 2025 13:37
@graycreate graycreate merged commit e0dfe68 into main Sep 9, 2025
4 checks passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Simplifies the bundletool keystore creation logic in the download-signed-apk job by removing complex fallback error handling that was causing failures. The fix creates a debug keystore upfront with a straightforward approach instead of using a try/catch pattern with output redirection.

  • Remove complex fallback logic with error handling that was causing exit code 8 failures
  • Create debug keystore upfront using a simple keytool command without output redirection
  • Use consistent keystore filename (debug.keystore instead of dummy.keystore)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@graycreate graycreate deleted the bugfix/bundletool-keystore-fix branch September 9, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants