-
Notifications
You must be signed in to change notification settings - Fork 48
ci: optimize pipeline triggers and release workflow #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -163,35 +163,27 @@ platform :ios do | |
| # Build the app | ||
| build_ipa | ||
|
|
||
| # Extract changelog for the current version | ||
| changelog_content = ChangelogHelper.extract_changelog(current_version) | ||
|
|
||
| # Upload to TestFlight | ||
| # NOTE: We skip waiting for build processing to avoid timeout issues. | ||
| # Apple's build processing can take 5-30 minutes, which often exceeds reasonable timeout limits. | ||
| # Distribution to testers can be done after processing completes using: fastlane distribute_beta | ||
| upload_to_testflight( | ||
| api_key: api_key, | ||
| skip_submission: false, | ||
| skip_waiting_for_build_processing: false, # Wait for processing before distribution | ||
| wait_processing_interval: 30, # Check every 30 seconds | ||
| wait_processing_timeout_duration: 900, # Wait up to 15 minutes for processing | ||
| distribute_external: true, # Distribute to external testers (public beta) | ||
| distribute_only: false, # Upload and distribute in one action | ||
| groups: ["Public Beta", "External Testers", "Beta Testers"], # Public beta groups | ||
| changelog: changelog_content, # Use changelog from CHANGELOG.md | ||
| notify_external_testers: true, # Send email notifications to external testers | ||
| uses_non_exempt_encryption: false, # Required for automatic distribution | ||
| submit_beta_review: true, # Automatically submit for Beta review | ||
| beta_app_description: "V2er is an elegant third-party client for V2EX forum", | ||
| beta_app_feedback_email: "[email protected]", | ||
| demo_account_required: false, # No demo account required | ||
| beta_app_review_info: { | ||
| contact_email: "[email protected]", | ||
| contact_first_name: "V2er", | ||
| contact_last_name: "Support", | ||
| contact_phone: "+86 13800138000", | ||
| notes: "This is a third-party client app for V2EX forum. No special account needed for testing." | ||
| } | ||
| skip_waiting_for_build_processing: true, # Don't wait - avoid timeout issues | ||
| distribute_external: false, # Can't distribute until Apple finishes processing | ||
| uses_non_exempt_encryption: false | ||
| # NOTE: changelog parameter intentionally omitted | ||
| # Even with skip_waiting_for_build_processing: true, providing a changelog | ||
| # causes fastlane to wait for the build to appear in App Store Connect, | ||
| # which defeats the purpose of skipping. Changelog can be added manually | ||
| # in App Store Connect or when distributing with: fastlane distribute_beta | ||
| ) | ||
|
|
||
| UI.success("✅ Build uploaded successfully to TestFlight!") | ||
| UI.important("📦 Build will be available for testing once Apple finishes processing (usually 5-30 minutes)") | ||
| UI.important("🔔 You can distribute to testers using: fastlane distribute_beta") | ||
|
|
||
| # Notify success | ||
| notification( | ||
| title: "V2er iOS", | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
betalane still validates that a changelog entry exists (line 112) but no longer uses it. This creates an inconsistency where developers are required to maintain the changelog, but it's not actually included in the TestFlight submission.Consider either:
fastlane distribute_betaThe current state may confuse developers about why changelog validation is required if the changelog isn't being used.