log the real client ip when using grpc transport#3606
Open
hann-wang wants to merge 1 commit intov2fly:masterfrom
Open
log the real client ip when using grpc transport#3606hann-wang wants to merge 1 commit intov2fly:masterfrom
hann-wang wants to merge 1 commit intov2fly:masterfrom
Conversation
Contributor
|
Thanks for the contribution. This function should be controlled via a option, rather than applied by default, as when listening directly, this ip address can be set by client. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3606 +/- ##
==========================================
+ Coverage 23.21% 23.23% +0.02%
==========================================
Files 836 837 +1
Lines 45454 45469 +15
==========================================
+ Hits 10552 10565 +13
- Misses 33685 33688 +3
+ Partials 1217 1216 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve: #1026
original pr: #1032
This PR rebases the original pr on top of the main branch.
Tested with a GRPC server behind NGINX proxy.