refactor: upgrade to v25 #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
reviewed
Oct 23, 2025
web-padawan
reviewed
Oct 23, 2025
sissbruecker
force-pushed
the
refactor/v25-upgrade
branch
from
43c1e63 to
584823d
Compare
web-padawan
approved these changes
Oct 28, 2025
| */ | ||
| @customElement("vcf-breadcrumbs") | ||
| export class VcfBreadcrumbs extends ResizeMixin(ElementMixin(ThemableMixin(PolylitMixin(LitElement)))) { | ||
| export class VcfBreadcrumbs extends ResizeMixin(ElementMixin(PolylitMixin(LitElement))) { |
There was a problem hiding this comment.
I wonder if we should add ThemeDetectionMixin here also just in case someone expects it to be present?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #10
ThemeDetectionMixin.ThemeableMixinfrom the component as it's not required anymore to apply its styles / theme, and applications should not rely on it as it will likely be dropped in the future