-
Notifications
You must be signed in to change notification settings - Fork 216
Fix broken charts styling examples, add Flow API example #4783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v24
Are you sure you want to change the base?
Conversation
AI Language ReviewThe update to the file has introduced a clear example of Java API styling for charts and expanded the CSS styling example in a meaningful way. However, the example for Java API includes a comment with the phrase "Point inside color," which is inconsistent with the rest of the comments in the example that use less conversational phrasing, like "Line color" or "Point outline color." It would be better to replace it with "Point fill color" for consistency. Additionally, ensure that all code snippets and descriptions maintain a consistent use of punctuation, such as periods at the end of statements. |
|
This PR is targeted at Vaadin 24. Does it apply to Vaadin 25 as well? |
Yes, it's equally applicable to V25. However, in the V25 docs, we need to mention that you need to enable shadow DOM style injection to use it. There is a note in the V25 Styling section about that: https://github.com/vaadin/docs/blob/main/articles/styling/index.adoc |
rolfsmeds
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More of a question than a request to change... otherwise looks good to me.
Would be great to port to V25 docs (where it also needs to be noted that component shadow DOM css styling needs to be enabled)
|
|
||
|
|
||
| [[css.styling.example2]] | ||
| == Exposing Chart Elements for Styling (Flow) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the only problem with this example that the css snippet is wrong (in that it needs to be applied to components/vaadin-chart.css?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've rechecked it now,
it also didn't include:
configuration.getChart().setStyledMode(true);
Should I restore it and modernize it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, we don't seem to have any other guidance for applying classnames to chart elements, so I think it would be good to retain it.
Solves:
#4782
#76 (sort of)
Changes: