Open
Conversation
sissbruecker
reviewed
Mar 6, 2026
Contributor
There was a problem hiding this comment.
IMO it would be preferable to identify why it's still used in production mode, which was supposed to not be the case with the previous PR. We don't need observability kit at runtime, we only need it for compiling the app.
Member
Author
There was a problem hiding this comment.
One option would be to not depend on Observability kit at all and exclude the Java classes using it from compilation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change in #4561 excluded observability kit dependency when running on dev mode to eliminate the
Observability agent is not runningerrors.The fix works but it causes Vaadin to generate the
package.jsonfile with a different set of dependencies when running in dev vs production mode. This results with local diffs to the file whenever running dsp:start.This PR removes the observability-kit exclusion and suppresses the "Observability agent is not running" error in dspublisher-script.js instead.