Skip to content

docs: correct and reformat the chart style property tables - #5985

Merged
web-padawan merged 1 commit into
mainfrom
docs/charts-style-property-tables
Sep 10, 2026
Merged

docs: correct and reformat the chart style property tables#5985
web-padawan merged 1 commit into
mainfrom
docs/charts-style-property-tables

Conversation

@DiegoCardoso

Copy link
Copy Markdown
Contributor

The tables on the Charts style properties page listed eight properties no rule reads any more, omitted eleven that exist, and gave --lumo-* variables as default values in a release whose default theme is Aura. They were also the last tables under articles/components/ still using the Default Value column that every other styling page dropped for Supported by.

Switching to the standard format removes all eighteen stale defaults along with the need to maintain any of them, so this does both at once.

Removed — verified inert: the four --vaadin-charts-contrast-*pct, tooltip-border-color, tooltip-background-opacity, color-positive, color-negative. Lumo still assigns the last four, but nothing reads them.

Added: surface, label, point-border, minor-grid-line, font-size, button-border-radius, button-disabled-label, candlestick-line, range-input-background, range-input-background-hover, tooltip-shadow.

Other Chart Colors is gone — removing the four dead contrast-*pct properties emptied it down to contrast, which moves to Common Properties.

Selector guidance kept, and now explained

The page says to use vaadin-chart {...}, which contradicts the html {...} advice on every other styling page, so it looked like drift worth fixing. It isn't: Lumo declares most of these properties on the chart element, and a value inherited from html never overrides a declared one. The page now says so.

Verification

Driven in a browser against Aura, Lumo and no theme:

Aura Lumo no theme
vaadin-chart {...} 38/38 38/38 38/38
html {...} 38/38 10/38 38/38

Every listed property was confirmed to change rendering — four chart configurations were needed, since point-border only applies to pie/column/bar/funnel/pyramid/treemap, the button properties need a range selector, and the tooltip ones need a visible tooltip. Every removed property was confirmed to change nothing, with live properties as controls on the same chart. Two hover-state properties rest on source alone; :hover can't be forced from script.

The documented set now matches the stylesheet exactly.

Part of vaadin/web-components#12700.

🤖 Generated with Claude Code

The tables listed eight properties no rule reads any more, omitted
eleven that exist, and gave --lumo-* variables as default values in a
release whose default theme is Aura. They were also the last tables
under articles/components/ still using the Default Value column that
every other styling page dropped for Supported by.

Switch to the standard format, which removes the stale defaults along
with the need to maintain any of them, and correct the membership. The
per-theme differences move into prose above the tables, where they don't
have to be repeated per row.

Keep the vaadin-chart {...} selector and say why it isn't html {...}:
Lumo declares most of these properties on the chart element, so a value
inherited from html never applies. Verified in the browser against Aura,
Lumo and no theme, along with every property listed and every one
removed.

Part of vaadin/web-components#12700.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@DiegoCardoso
DiegoCardoso force-pushed the docs/charts-style-property-tables branch from ceacc31 to e6e3f1b Compare September 9, 2026 15:03
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

Preview Deployment

This PR has been deployed for preview.

URL: https://docs-preview-pr-5985.fly.dev

Changed pages

Added content is highlighted in green; removed content is marked in red on each page.

Built from fdb0eeb

@web-padawan
web-padawan removed the request for review from jouni September 10, 2026 06:47
@DiegoCardoso DiegoCardoso added the target/v25.2 Automatically cherry-pick to the v25.2 branch label Sep 10, 2026
@web-padawan
web-padawan merged commit 76d6dff into main Sep 10, 2026
9 checks passed
@web-padawan
web-padawan deleted the docs/charts-style-property-tables branch September 10, 2026 06:50
web-padawan pushed a commit that referenced this pull request Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-picked-v25.2 target/v25.2 Automatically cherry-pick to the v25.2 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants