docs: one section for theme name bindings, and no dark in the examples - #6000
Open
manolo wants to merge 3 commits into
Open
docs: one section for theme name bindings, and no dark in the examples#6000manolo wants to merge 3 commits into
manolo wants to merge 3 commits into
Conversation
Two sections on the same page taught the same thing, and both used "dark" as the example theme name, which reads as the way to switch an application to dark mode. It is not: the theme attribute lands on the component, and under Aura it does nothing at all.
Preview DeploymentThis PR has been deployed for preview. URL: https://docs-preview-pr-6000.fly.dev Changed pagesAdded content is highlighted in green; removed content is marked in red on each page.
Built from 9520718 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5995
darkin the examples: theme names are variants likesmall.@ColorSchemeandPage.setColorScheme()are the color scheme API, thedarktheme name is a Lumo selector on<body>, and tests assertgetColorScheme().