refactor!: make various deprecated API private or remove where possible (#4600)

Author: tomivirkki

vaadin-list-box-flow-parent/vaadin-list-box-flow/src/main/java/com/vaadin/flow/component/listbox/ListBoxBase.java

@@ -141,11 +141,8 @@ protected void onDetach(DetachEvent detachEvent) {
      * Gets the data provider.
      *
      * @return the data provider, not {@code null}
-     * @deprecated use {@link #getListDataView()} or
-     *             {@link #getGenericDataView()} instead
      */
-    @Deprecated
-    public DataProvider<ITEM, ?> getDataProvider() {
+    private DataProvider<ITEM, ?> getDataProvider() {
         return dataProvider.get();
     }
 
@@ -382,17 +379,6 @@ public ListBoxListDataView<ITEM> setItems(
         return getListDataView();
     }
 
-    /**
-     * {@inheritDoc}
-     *
-     * @deprecated Because the stream is collected to a list anyway, use
-     *             {@link HasListDataView#setItems(Collection)} instead.
-     */
-    @Deprecated
-    public void setItems(Stream<ITEM> streamOfItems) {
-        setItems(DataProvider.fromStream(streamOfItems));
-    }
-
     /**
      * Gets the list data view for the ListBox. This data view should only be
      * used when the items are in-memory and set with:

vaadin-radio-button-flow-parent/vaadin-radio-button-flow/src/main/java/com/vaadin/flow/component/radiobutton/RadioButtonGroup.java

@@ -267,17 +267,6 @@ public RadioButtonGroupListDataView<T> setItems(
         return getListDataView();
     }
 
-    /**
-     * {@inheritDoc}
-     *
-     * @deprecated Because the stream is collected to a list anyway, use
-     *             {@link HasListDataView#setItems(Collection)} instead.
-     */
-    @Deprecated
-    public void setItems(Stream<T> streamOfItems) {
-        setItems(DataProvider.fromStream(streamOfItems));
-    }
-
     /**
      * Gets the list data view for the RadioButtonGroup. This data view should
      * only be used when the items are in-memory and set with:
@@ -400,11 +389,8 @@ protected void onDetach(DetachEvent detachEvent) {
      * Gets the data provider.
      *
      * @return the data provider, not {@code null}
-     * @deprecated use {@link #getListDataView()} or
-     *             {@link #getGenericDataView()} instead
      */
-    @Deprecated
-    public DataProvider<T, ?> getDataProvider() {
+    private DataProvider<T, ?> getDataProvider() {
         return Optional.ofNullable(dataProvider).map(AtomicReference::get)
                 .orElse(null);
     }

vaadin-renderer-flow-parent/vaadin-renderer-flow/src/main/java/com/vaadin/flow/data/renderer/LocalDateRenderer.java

@@ -160,29 +160,6 @@ public LocalDateRenderer(ValueProvider<SOURCE, LocalDate> valueProvider,
         this(valueProvider, formatter, "");
     }
 
-    /**
-     * Creates a new LocalDateRenderer.
-     * <p>
-     * The renderer is configured to render with the given formatter.
-     *
-     * @param valueProvider
-     *            the callback to provide a {@link LocalDate} to the renderer,
-     *            not <code>null</code>
-     * @param formatter
-     *            the formatter to use, not <code>null</code>
-     * @param nullRepresentation
-     *            the textual representation of the <code>null</code> value
-     * @deprecated Via this constructor renderer is not serializable, use
-     *             {@link LocalDateRenderer(ValueProvider, SerializableSupplier,
-     *             String)} instead.
-     *
-     */
-    @Deprecated
-    public LocalDateRenderer(ValueProvider<SOURCE, LocalDate> valueProvider,
-            DateTimeFormatter formatter, String nullRepresentation) {
-        this(valueProvider, () -> formatter, nullRepresentation);
-    }
-
     /**
      * Creates a new LocalDateRenderer.
      * <p>

vaadin-select-flow-parent/vaadin-select-flow/src/main/java/com/vaadin/flow/component/select/Select.java

@@ -495,17 +495,6 @@ public boolean isAutofocus() {
         return getElement().getProperty("autofocus", false);
     }
 
-    /**
-     * {@inheritDoc}
-     *
-     * @deprecated Because the stream is collected to a list anyway, use
-     *             {@link HasListDataView#setItems(Collection)} instead.
-     */
-    @Deprecated
-    public void setItems(Stream<T> streamOfItems) {
-        setItems(DataProvider.fromStream(streamOfItems));
-    }
-
     private void setDataProvider(DataProvider<T, ?> dataProvider) {
         this.dataProvider.set(dataProvider);
         DataViewUtils.removeComponentFilterAndSortComparator(this);