fix: Grid column respects custom reversed comparator and improves serialization (#3926) #8088
+158
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ialization (#3926) - Store the original Comparator object instead of just method references - Preserve SerializableComparator instances when provided - Respect custom reversed() implementations for descending sort - Fix serialization issues when non-serializable comparators are used The column now stores the full comparator object, allowing it to: 1. Use custom reversed() implementations when sorting descending 2. Preserve serialization capability when SerializableComparator is provided 3. Only create method references as a fallback for non-serializable comparators Fixes #3926 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
The API seems to be a lie as there is |
There was a problem hiding this comment.
It looks like the change breaks serialization:
java.lang.RuntimeException: serializeAndDeserializeUi_noExceptionIsThrown[any_Chrome_](com.vaadin.flow.component.grid.it.GridLitRendererSerializationIT)
Fixes issue where Grid ignored custom reversed() implementations when sorting columns in descending order. Now stores both the comparator and its reversed version at assignment time, preserving custom reverse logic (e.g., for "favorites" that stay on top regardless of direction). Fixes #3926 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The column now stores the full comparator object, allowing it to:
Fixes #3926