feat: add constructors for text binding to Button #8499
Conversation
|
|
platosha
force-pushed
the
feat/signals-constructor-bindtext
branch
from
92f6c71 to
1032ae5
Compare
platosha
changed the title
DiegoCardoso
left a comment
DiegoCardoso
left a comment
There was a problem hiding this comment.
Do we need to add integration tests to check the signals behavior? Wouldn't it be enough to add unit tests instead?
One reason for ITs on my mind is the dynamic Button behavior regarding the icon. Some aspects are challenging to assert: it's quite possible to make the icon accidentally disappear from the DOM upon a text change, and this error condition would be hard to detect from a unit test context. |
DiegoCardoso
left a comment
DiegoCardoso
left a comment
There was a problem hiding this comment.
IMO this PR could've been split to remove the noise from the MockUI refactor.
Added a couple of comments.
...arent/vaadin-button-flow-integration-tests/src/main/resources/vaadin-featureflags.properties
Outdated
Show resolved
Hide resolved
...on-flow-parent/vaadin-button-flow/src/main/java/com/vaadin/flow/component/button/Button.java
Outdated
Show resolved
Hide resolved
mshabarov
left a comment
mshabarov
left a comment
There was a problem hiding this comment.
Filed one comment about potential breaking change, but otherwise no comment in addition to these Diego has already mentioned.
...-flow-integration-tests/src/main/java/com/vaadin/flow/component/button/tests/ButtonView.java
Show resolved
Hide resolved
platosha
force-pushed
the
feat/signals-constructor-bindtext
branch
from
f0b04ba to
73b03c5
Compare
See #8507 |
platosha
force-pushed
the
feat/signals-constructor-bindtext
branch
from
73b03c5 to
c439e17
Compare
Connected to: vaadin/flow#23193 - Add new constructors and methods to support binding text to signals - Refactor internal text handling using a Text node - Improve icon slot management and theme attribute updates
- Use single `SignalPropertySupport` instance for managing signal-originating button text changes - Replace direct DOM updates with centralized handler method - Maintain consistency between setText and bindText operations
platosha
force-pushed
the
feat/signals-constructor-bindtext
branch
from
adea1db to
cbfacd4
Compare
|
Connected to: vaadin/flow#23193
Depends on #8507