feat: create RangeSlider component #8503
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add RangeSlider component that allows selecting a numeric range with two handles. Includes RangeSliderValue record for the start/end value pair and updates SliderBase to support custom value converters. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Move the "start value cannot be greater than end value" validation from RangeSlider#setValue to the RangeSliderValue compact constructor, ensuring the invariant is enforced at construction time. Co-Authored-By: Claude Opus 4.5 <[email protected]>
vursen
changed the title
Add RangeSliderTest with tests for constructors, setValue validation, interface implementations, and property setters/getters. Add RangeSliderSerializableTest for serialization testing. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Add constructors with various parameter combinations including label, min/max range, step, initial value, and value change listener. Also add corresponding unit tests for all new constructors. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Add RangeSliderElement testbench class and basic IT test that verifies min, max, step, and value properties are correctly set on the component. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Update RangeSlider to use SerializableBiFunction for value converters, allowing validation during conversion. Throw exceptions for invalid min/max/step changes instead of logging warnings. Remove RangeSliderWarningsTest as warnings are replaced with exceptions. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Collaborator
TC Format Checker Report - 13:44 - 26 - Jan
Here is the list of files with format issues in your PR: |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add RangeSlider component that allows selecting a numeric range with two handles. Includes RangeSliderValue record for the start/end value pair and updates SliderBase to support custom value converters.
Depends on
Fixes #8481
Type of change