Skip to content

refactor: replace Reflections with ClassGraph for classpath scanning #22973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tltv merged 5 commits into from
Jan 8, 2026
Merged

refactor: replace Reflections with ClassGraph for classpath scanning #22973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ee9bb22
refactor: replace Reflections with ClassGraph for classpath scanning
mcollovati Dec 11, 2025
df8f920
minor refactoring
mcollovati Dec 11, 2025
c2a16f4
remove javassist dependency
mcollovati Dec 12, 2025
309668f
update test
mcollovati Dec 12, 2025
0c5ed92
apply default package rejections
mcollovati Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...-plugins/flow-dev-bundle-plugin/src/main/java/com/vaadin/flow/plugin/maven/Reflector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public final class Reflector {
"org.eclipse.sisu");
// Dependency required by the plugin but not provided by Flow at runtime
private static final Set<String> REQUIRED_PLUGIN_DEPENDENCIES = Set.of(
"org.reflections:reflections:jar",
"io.github.classgraph:classgraph:jar",
"org.zeroturnaround:zt-exec:jar");
private static final ScopeArtifactFilter PRODUCTION_SCOPE_FILTER = new ScopeArtifactFilter(
Artifact.SCOPE_COMPILE_PLUS_RUNTIME);
Expand Down
4 changes: 3 additions & 1 deletion flow-plugins/flow-maven-plugin/src/it/plugin-pinned-deps-project/invoker.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,6 @@
# the License.
#

invoker.goals=clean package
# Build will fail with a ClassNotFoundException if using the outdate version
# of the plugin required dependencies.
invoker.goals=clean package -ntp
6 changes: 3 additions & 3 deletions flow-plugins/flow-maven-plugin/src/it/plugin-pinned-deps-project/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@
<version>${flow.version}</version>
</dependency>
<dependency>
<groupId>org.reflections</groupId>
<artifactId>reflections</artifactId>
<version>0.9.10</version>
<groupId>io.github.classgraph</groupId>
<artifactId>classgraph</artifactId>
<version>4.0.0</version>
</dependency>
<dependency>
<groupId>org.zeroturnaround</groupId>
Expand Down
2 changes: 1 addition & 1 deletion flow-plugins/flow-maven-plugin/src/main/java/com/vaadin/flow/plugin/maven/Reflector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public final class Reflector {
"org.eclipse.sisu");
// Dependency required by the plugin but not provided by Flow at runtime
private static final Set<String> REQUIRED_PLUGIN_DEPENDENCIES = Set.of(
"org.reflections:reflections:jar",
"io.github.classgraph:classgraph:jar",
"org.zeroturnaround:zt-exec:jar");
private static final ScopeArtifactFilter PRODUCTION_SCOPE_FILTER = new ScopeArtifactFilter(
Artifact.SCOPE_COMPILE_PLUS_RUNTIME);
Expand Down
25 changes: 3 additions & 22 deletions flow-plugins/flow-plugin-base/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,28 +29,9 @@
<artifactId>license-checker</artifactId>
</dependency>
<dependency>
<groupId>org.reflections</groupId>
<artifactId>reflections</artifactId>
<version>0.10.2</version>
<exclusions>
<exclusion>
<groupId>org.dom4j</groupId>
<artifactId>dom4j</artifactId>
</exclusion>
<exclusion>
<groupId>com.google.code.gson</groupId>
<artifactId>gson</artifactId>
</exclusion>
<exclusion>
<groupId>org.javassist</groupId>
<artifactId>javassist</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>org.javassist</groupId>
<artifactId>javassist</artifactId>
<version>${javassist.version}</version>
<groupId>io.github.classgraph</groupId>
<artifactId>classgraph</artifactId>
<version>4.8.184</version>
</dependency>
<dependency>
<groupId>org.zeroturnaround</groupId>
Expand Down
Loading
Loading