fix: do not leak internally used dependencies to actual apps, not even as optionals #23011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the configs need to be reviewed, full build not done, opening draft PR for that...
mstahv
changed the title
mcollovati
reviewed
Dec 22, 2025
Artur-
reviewed
Dec 22, 2025
mshabarov
reviewed
Dec 22, 2025
mshabarov
reviewed
Dec 23, 2025
mshabarov
reviewed
Dec 23, 2025
Contributor
mshabarov
left a comment
mshabarov
left a comment
There was a problem hiding this comment.
I don't have comments, looks fine. The question is shall we test it before merging, or shall we test with the alpha pre-release, which is easier. Merge and test sounds better to me.
…encies-leaking-from-vaadin-dev
mcollovati
approved these changes
Jan 8, 2026
|
mshabarov
approved these changes
Jan 9, 2026
mshabarov
deleted the
bugfix/commons-dependencies-leaking-from-vaadin-dev
branch
vaadin-bot
added a commit
that referenced
this pull request
Jan 9, 2026
…n as optionals (#23011) (#23152) Uses shade plugin to pull in some transitive dependencies to internal "flow-build-util" module. Although they are not ending up to the actual production artifact, they lower the DX as in IDE it may appear one has them evailable. Fixes #23007 Co-authored-by: Matti Tahvonen <matti@vaadin.com>
Collaborator
|
This ticket/PR has been released with Vaadin 25.1.0-alpha1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses shade plugin to pull in some transitive dependencies to internal "flow-build-util" module. Although they are not ending up to the actual production artifact, they lower the DX as in IDE it may appear one has them evailable.
Fixes #23007