fix!: prevent lumo utility classes to be imported automatically #23074
Conversation
flow-server/src/main/resources/plugins/application-theme-plugin/theme-handle.js
Outdated
Show resolved
Hide resolved
flow-server/src/main/resources/plugins/application-theme-plugin/theme-handle.js
Outdated
Show resolved
Hide resolved
|
|
||
| if (themeJson.lumoImports) { | ||
| const themeName = basename(themeFolder); | ||
| logger.warn( |
There was a problem hiding this comment.
I was not able to observe this warning anywhere. Where should it show up? Should it be in the server logs instead?
There was a problem hiding this comment.
You need to enable debug logs for dev server output tracker in dev mode (I don't remember the specific logger category right now)
There was a problem hiding this comment.
If this needs a logging configuration, then most likely this would never be seen by users, maybe it's better to place this warning in Java?
There was a problem hiding this comment.
Can probably be checked in ThemeValidationUtil
There was a problem hiding this comment.
Added the log message in TaskUpdateThemeImport
mshabarov
changed the title
|
mshabarov
deleted the
issues/22467-legacy_theme_dont_load_lumo_utilitites
branch
|
Hi @mcollovati and @mshabarov, when i performed cherry-pick to this commit to 25.0, i have encountered the following issue. Can you take a look and pick it manually? |
Fixes #22467 --------- Co-authored-by: Mikhail Shabarov <[email protected]>
…) (#23174) Fixes #22467 --------- Co-authored-by: Mikhail Shabarov <[email protected]>
Fixes #22467