feat: Make two-way signal bindings explicit with a write callback parameter #23469
+246
−87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ameter Change bindValue(WritableSignal<V>) to bindValue(Signal<V>, SerializableConsumer<V>) so that two-way bindings require an explicit write-back callback. This forces developers to acknowledge when user input is received, providing an additional layer of safety. The first parameter is a read-only Signal for the signal-to-component direction. The second parameter is the callback for propagating value changes back to the signal. After invoking the callback, the signal is re-consulted via peek() and if the value differs, the component reverts to the signal's value. A null callback creates a read-only binding that throws on setValue while attached.
tltv
requested changes
Feb 10, 2026
| throw new BindingActiveException(); | ||
| } | ||
|
|
||
| this.readSignal = valueSignal; |
Member
There was a problem hiding this comment.
readSignal is not needed here as it's already stored in SignalBindingFeature. writeCallback should be stored in SignalBindingFeature instead.
| SignalBindingFeature.VALUE, newValue); | ||
| } | ||
| }); | ||
| if (!valueSetFromSignal && readSignal != null |
Member
There was a problem hiding this comment.
Probably better if old code is just replaced here so that this new logic is executed inside if (component.isAttached()) { ... } block. Reading signal and consumer from the SignalBindingFeature feature.
…ractFieldSupport Move the readSignal and writeCallback fields out of AbstractFieldSupport and into SignalBindingFeature where the signal is already stored. The setValue write-back logic now reads both the signal and callback from the feature using the existing getFeatureIfInitialized pattern, keeping state centralized in one place.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change bindValue(WritableSignal) to bindValue(Signal, SerializableConsumer) so that two-way bindings require an explicit write-back callback. This forces developers to acknowledge when user input is received, providing an additional layer of safety.
The first parameter is a read-only Signal for the signal-to-component direction. The second parameter is the callback for propagating value changes back to the signal. After invoking the callback, the signal is re-consulted via peek() and if the value differs, the component reverts to the signal's value. A null callback creates a read-only binding that throws on setValue while attached.