fix: restore icon size workaround #10296
Open
+227
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
reviewed
Oct 6, 2025
| ? superclass | ||
| : class extends ResizeMixin(superclass) { | ||
| static get observers() { | ||
| return ['__iconFontSizeMixinfontChanged(iconClass, char, ligature)']; |
There was a problem hiding this comment.
Could use Lit lifecycle callback instead:
updated(props) {
super.updated(props);
if (props.has('iconClass') || props.has('char') || props.has('ligature')) {
this.__updateFontIconSize();
}
}This should make it unnecessary to call method in ready(), as updated() runs synchronously ready(), unlike complex observers that run before, and therefore single invocation for method should be enough.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reverts and adds a new check for the case where the
<vaadin-icon>is attached to an element with shadow root.Fixes vaadin/flow-components#8084
Type of change