refactor: only re-render affected rows on grid selection change#11397
Open
refactor: only re-render affected rows on grid selection change#11397
Conversation
vursen
changed the title
Instead of requesting a full content update when selectedItems changes, only update the rows whose selection state actually changed. This avoids unnecessary re-rendering of all visible rows when selecting or deselecting a single item.
vursen
force-pushed
the
fix/grid-selection-render-optimization
branch
from
52e6f06 to
00d7c0b
Compare
|
tomivirkki
reviewed
Mar 21, 2026
Member
There was a problem hiding this comment.
I guess there can be use-cases where value on some cells depend on the grid's selection state
Kapture.2026-03-21.at.14.12.40.mp4
Contributor
Author
There was a problem hiding this comment.
I think it should be the developer's responsibility to ensure renderers get triggered when selection changes. They could, for example, accomplish that by adding selectedItems to the renderer's deps:
.renderer="${bodyRenderer(() => `${selectedItems.length} selected`, [selectedItems])}"The fact that all renderers were automatically re-rendered on selection looks like an unintended side effect to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR optimizes
__selectedItemsChangedinSelectionMixinto only call__updateRowon rows whose selection state actually changed, instead of triggering a full content update for all rendered rows.