Skip to content

fix: allow passing non-element nodes to getClosestElement #11428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vursen merged 1 commit into from
Mar 31, 2026
+10 −6
Merged

fix: allow passing non-element nodes to getClosestElement #11428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/component-base/src/dom-utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ export function getClosestElement(selector, node) {
return null;
}

return node.closest(selector) || getClosestElement(selector, node.getRootNode().host);
return node.closest?.(selector) || getClosestElement(selector, node.getRootNode().host);
}

/**
Expand Down
14 changes: 9 additions & 5 deletions packages/component-base/test/dom-utils.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ describe('dom-utils', () => {
});

describe('getClosestElement', () => {
let element;
let element, node;

const tag = defineCE(
class ShadowElement extends HTMLElement {
Expand All @@ -65,26 +65,30 @@ describe('dom-utils', () => {

it('should return the closest element matching the selector within the shadow root', () => {
element = fixtureSync(`<${tag}></${tag}>`);
const node = element.shadowRoot.querySelector('.child');
node = element.shadowRoot.querySelector('.child');
const expected = element.shadowRoot.querySelector('.parent-2');
expect(getClosestElement('.parent', node)).to.equal(expected);
});

it('should return the closest element matching the selector across the shadow root', () => {
element = fixtureSync(`<div class="wrapper"><${tag}></${tag}></div>`);
const node = element.querySelector(tag).shadowRoot.querySelector('.parent');

node = element.querySelector(tag).shadowRoot;
expect(getClosestElement('.wrapper', node)).to.equal(element);

node = element.querySelector(tag).shadowRoot.querySelector('.parent');
expect(getClosestElement('.wrapper', node)).to.equal(element);
});

it('should return null when no closest element is found', () => {
element = fixtureSync(`<${tag}></${tag}>`);
const node = element.shadowRoot.querySelector('.child');
node = element.shadowRoot.querySelector('.child');
expect(getClosestElement('.not-existing-class', node)).to.be.null;
});

it('should return the passed element if it matches the selector', () => {
element = fixtureSync(`<${tag}></${tag}>`);
const node = element.shadowRoot.querySelector('.child');
node = element.shadowRoot.querySelector('.child');
expect(getClosestElement('.child', node)).to.equal(node);
});
});
Expand Down
Loading