test: add missing resetMouse to tests using sendMouse #8655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
test/missing-reset-mouse
branch
from
526947b to
6411712
Compare
web-padawan
force-pushed
the
test/missing-reset-mouse
branch
from
6411712 to
1303ff4
Compare
|
sissbruecker
approved these changes
Feb 7, 2025
vaadin-bot
pushed a commit
that referenced
this pull request
Feb 7, 2025
vaadin-bot
pushed a commit
that referenced
this pull request
Feb 7, 2025
web-padawan
added a commit
that referenced
this pull request
Feb 7, 2025
Co-authored-by: Serhii Kulykov <[email protected]>
web-padawan
added a commit
that referenced
this pull request
Feb 7, 2025
Co-authored-by: Serhii Kulykov <[email protected]>
|
This ticket/PR has been released with Vaadin 24.7.0.alpha10 and is also targeting the upcoming stable 24.7.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some tests using
sendMouse()are currently missingresetMouse(), which can cause issues after the Puppeteer version update e.g. infield-highlightertests failing in #8654. This should fix that.Type of change