Add writeValue/readValue to std and pkg serializers#25
Draft
Conversation
nitely
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if the user does
defaultSerialization(flavor, T)whereTis a type in std/pkg modules, and they forget to actually import such module (or remove the import later by mistake), the default serialization will use theobjectone (if T is an object), which if lucky will throw a comptime error (or worse it will serialize the value giving an incorrect encoded output). This PR fixes this by not makingdefaultSerializationneeded for std/pkg modules.The
write*andread*procs are still needed when the flavor/format hasdefaultSerialization(flavor, object), so the generated code will call these functions, as the generated readValue/writeValue match harder than the readValue/writeValue this PR adds.Changes:
writeValueandreadValueto thestdandpkgmodules. This makes it sodefaultSerializationis no longer needed to enable these.This seems backward compatible.
Edit: the problem is really
defaultSerialization(flavor, object)which enables a default serialization for any object, maybe the solution is for flavors to not enable it which is already the case in usage I've seen... and the current behavior makes sense... it could just be documented... mmhRef #2