Skip to content

Conversation

@richard-ramos
Copy link
Member

@richard-ramos richard-ramos commented Feb 20, 2025

This PR enables quic transport with a proper TLS backend, and tests connection and comms between two nodes.
Do note that one of the commits changes the not implemented assertion to something that gives a bit more context, so it's easier to know which abstract method a dev forgot to implement.

@richard-ramos richard-ramos force-pushed the tls branch 14 times, most recently from c1294d4 to 8d7e551 Compare March 3, 2025 20:40
Base automatically changed from tls to master March 4, 2025 12:05
@richard-ramos richard-ramos force-pushed the tls-quic branch 6 times, most recently from 55c664a to 04d3bea Compare March 5, 2025 20:24
@richard-ramos richard-ramos marked this pull request as ready for review March 5, 2025 22:52
@richard-ramos
Copy link
Member Author

Looks like there are some issues with building mbed-tls in windows, macos(arm64) and linux(i386).
Will try to fix this in #1278 as it seems that certificate generation has trouble on those OSs

Copy link
Member

@vladopajic vladopajic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@richard-ramos richard-ramos force-pushed the tls-quic branch 3 times, most recently from 68b970f to b8bac59 Compare March 25, 2025 01:32
@richard-ramos richard-ramos merged commit 340ea05 into master Mar 26, 2025
18 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to done in nim-libp2p Mar 26, 2025
@richard-ramos richard-ramos deleted the tls-quic branch March 26, 2025 14:17
@vladopajic
Copy link
Member

🚀🚀🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants