Replace nimcrypto SHA256 with BLS#1291
Closed
munna0908 wants to merge 5 commits intovacp2p:multihash-poseidon2from
Closed
Replace nimcrypto SHA256 with BLS#1291munna0908 wants to merge 5 commits intovacp2p:multihash-poseidon2from
munna0908 wants to merge 5 commits intovacp2p:multihash-poseidon2from
Conversation
Co-authored-by: kaiserd <1684595+kaiserd@users.noreply.github.com>
dryajov
approved these changes
Mar 18, 2025
Contributor
|
going to push directly to our running branch #974 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While running benchmarks in nim-codex, we identified that the nimcrypto SHA256 hash function is slow. Therefore, we are replacing it with blst_sha256, which outperforms the nimcrypto implementation in most scenarios.