chore: hide autotls under compile flag#1533
Conversation
e868a35 to
dc0b82a
Compare
dc0b82a to
0613d96
Compare
| @@ -1,509 +1,519 @@ | |||
| import options, sequtils, strutils, json, uri | |||
There was a problem hiding this comment.
curious if what's the better way to do this.
- could we leave types and types definitions but just remove
withAutotlsmethod in switch - then we technically disabled the feature? - adding
when defined(libp2p_autotls_support):in front of whole file removes line history (sometimes vary interesting info)
There was a problem hiding this comment.
the long-term plan is to integrate -d support with nimble feature flags using some suitable convention that has yet to be set in stone - it might be worth to experiment with newer nimble versions to understand what this could look like.
There was a problem hiding this comment.
could we leave types and types definitions but just remove withAutotls method in switch - then we technically disabled the feature?
I can try this.
it might be worth to experiment with newer nimble versions.
This sounds good, but lets do it on a separate PR whose scope is experimenting with that feature, while getting this PR merged ASAP to fix the error found by @jakubgs
d9ec94a to
aa66b34
Compare
aa66b34 to
9b36a66
Compare
Adds a
-d:libp2p_autotls_supportflag to enable the usage of AutoTLSAs suggested by @arnetheduck, we're disabling this feature, as any additional dependency is a potential security issue.
cc: @tersec