Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2148 +/- ##
==========================================
+ Coverage 72.83% 72.87% +0.04%
==========================================
Files 154 154
Lines 18939 18939
Branches 19 19
==========================================
+ Hits 13794 13802 +8
+ Misses 5145 5137 -8 🚀 New features to boost your workflow:
|
Contributor
|
https://github.com/vacp2p/nim-libp2p/actions/runs/22966107104/job/66669986736?pr=2148 is caused by |
Contributor
|
@tersec so we need that fix before using 2.2.8, no? |
Contributor
Separate things. Using 2.2.8 rather than 2.2.6 to test makes sense anyway, as 2.2.8 is now the current 2.2.x version. However, there's still an issue with 2.2.8 with ORC, so testing ORC in CI isn't ready yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #2077