Skip to content

chore: test ORC memory management#2148

Draft
narimiran wants to merge 2 commits intovacp2p:masterfrom
narimiran:test-orc
Draft

chore: test ORC memory management#2148
narimiran wants to merge 2 commits intovacp2p:masterfrom
narimiran:test-orc

Conversation

@narimiran
Copy link
Contributor

@narimiran narimiran commented Mar 11, 2026

close #2077

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.87%. Comparing base (e7636db) to head (df2cc9e).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2148      +/-   ##
==========================================
+ Coverage   72.83%   72.87%   +0.04%     
==========================================
  Files         154      154              
  Lines       18939    18939              
  Branches       19       19              
==========================================
+ Hits        13794    13802       +8     
+ Misses       5145     5137       -8     

see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tersec
Copy link
Contributor

tersec commented Mar 12, 2026

https://github.com/vacp2p/nim-libp2p/actions/runs/22966107104/job/66669986736?pr=2148

[Suite  ] channel half-closed
  [Test   ]           (local close) - should close for write
  [OK     ] (  0.00s) (local close) - should close for write
  [Test   ]           (local close) - should allow reads until remote closes
  [OK     ] (  0.00s) (local close) - should allow reads until remote closes
  [Test   ]           (remote close) - channel should close for reading by remote
  [OK     ] (  0.00s) (remote close) - channel should close for reading by remote
  [Test   ]           (remote close) - channel should allow writing on remote close
Traceback (most recent call last)
/home/runner/work/nim-libp2p/nim-libp2p/tests/tools/unittest.nim(18) test_mplex
/home/runner/work/nim-libp2p/nim-libp2p/tests/tools/unittest.nim(18) testSuite
/home/runner/work/nim-libp2p/nim-libp2p/nimbledeps/pkgs2/unittest2-0.2.4-746106a4dfefffce497f1693733f1c1513b5c62c/unittest2.nim(1170) testSuite
/home/runner/work/nim-libp2p/nim-libp2p/nimbledeps/pkgs2/unittest2-0.2.4-746106a4dfefffce497f1693733f1c1513b5c62c/unittest2.nim(1097) runDirect
/home/runner/work/nim-libp2p/nim-libp2p/tests/tools/unittest.nim(40) runTest`gensym1176
/home/runner/work/nim-libp2p/nim-libp2p/nimbledeps/pkgs2/chronos-4.0.4-b0716543b76ab26376f43a859aca5ccf030bc641/chronos/internal/asyncfutures.nim(660) waitFor
/home/runner/work/nim-libp2p/nim-libp2p/nimbledeps/pkgs2/chronos-4.0.4-b0716543b76ab26376f43a859aca5ccf030bc641/chronos/internal/asyncfutures.nim(635) pollFor
/home/runner/work/nim-libp2p/nim-libp2p/nimbledeps/pkgs2/chronos-4.0.4-b0716543b76ab26376f43a859aca5ccf030bc641/chronos/internal/asyncengine.nim(150) poll
/home/runner/work/nim-libp2p/nim-libp2p/nimbledeps/pkgs2/chronos-4.0.4-b0716543b76ab26376f43a859aca5ccf030bc641/chronos/internal/asyncfutures.nim(1152) cb
/home/runner/work/nim-libp2p/nim-libp2p/nim/lib/system.nim(938) reset
/home/runner/work/nim-libp2p/nim-libp2p/nim/lib/system/arc.nim(200) nimDestroyAndDispose
SIGSEGV: Illegal storage access. (Attempt to read from nil?)

is caused by

@gmelodie
Copy link
Contributor

@tersec so we need that fix before using 2.2.8, no?

@vladopajic vladopajic changed the title chore: close #2077, test ORC memory management chore: test ORC memory management Mar 13, 2026
@vladopajic vladopajic marked this pull request as draft March 13, 2026 11:30
@tersec
Copy link
Contributor

tersec commented Mar 15, 2026

@tersec so we need that fix before using 2.2.8, no?

Separate things. Using 2.2.8 rather than 2.2.6 to test makes sense anyway, as 2.2.8 is now the current 2.2.x version. However, there's still an issue with 2.2.8 with ORC, so testing ORC in CI isn't ready yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: new

Development

Successfully merging this pull request may close these issues.

test ORC in CI and otherwise in Nim 2.2

4 participants