chore: make lpthread optional if using windows with clang#65
chore: make lpthread optional if using windows with clang#65richard-ramos merged 2 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR modifies Windows-specific compilation flags in the lsquic FFI bindings to make pthread linking conditional on the clang compiler and removes the _WIN32_WINNT macro definition. The changes aim to improve Windows build compatibility across different compiler toolchains.
Changes:
- Made pthread library linking conditional on clang compiler for Windows builds
- Removed the
_WIN32_WINNT=0x0600Windows version macro definition
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
richard-ramos
force-pushed
the
fix/lpthread
branch
from
068c8f4 to
914c0f3
Compare
Also removes _WIN32_WINNT... maybe it's unneeded now?
richard-ramos
force-pushed
the
fix/lpthread
branch
from
914c0f3 to
a0298ed
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
richard-ramos
requested review from
Copilot,
gmelodie and
vladopajic
and removed request for
a team
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Also removes _WIN32_WINNT as it is not needed
as seen in status-im/nimbus-eth2#8025
cc: @tersec