fix: work around more path separator mismatches in static block#67
Merged
richard-ramos merged 2 commits intomainfrom Feb 25, 2026
Merged
fix: work around more path separator mismatches in static block#67richard-ramos merged 2 commits intomainfrom
richard-ramos merged 2 commits intomainfrom
Conversation
tersec
requested review from
richard-ramos and
vladopajic
and removed request for
a team
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
richard-ramos
approved these changes
Feb 25, 2026
| localPassC: | ||
| "-D_HAS_EXCEPTIONS=0 -DWIN32_LEAN_AND_MEAN -DNOMINMAX -D_CRT_SECURE_NO_WARNINGS" | ||
| .} | ||
| {.passl: "-lstdc++".} |
Member
There was a problem hiding this comment.
Interesting! how come the CI worked without this?
Contributor
There was a problem hiding this comment.
this is actually wrong - which C++ library should be used depends on how the c++ compiler was compiled, not the platform - ie clang might use either c++ or stdc++ depending on the distro
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More
make dist-win64fixes. See also:currentSourcePathorstaticReadshould normalize path nim-lang/Nim#25409