Skip to content

Comments

Fix PHP 8.4 deprecation notices#121

Merged
jooname merged 1 commit intovaimo:masterfrom
Dstny-One:php8.4
Apr 17, 2025
Merged

Fix PHP 8.4 deprecation notices#121
jooname merged 1 commit intovaimo:masterfrom
Dstny-One:php8.4

Conversation

@michaelarnauts-dstny
Copy link
Contributor

Fixes #117 by correcting the deprecation notices.

@jooname jooname merged commit e1422d7 into vaimo:master Apr 17, 2025
@jooname
Copy link
Contributor

jooname commented Apr 17, 2025

Thank you for the contribution! This should be now available in 5.2.1 release of the package.

@heldchen
Copy link

thank both, appreciated!

@hostep
Copy link
Contributor

hostep commented Apr 17, 2025

@jooname: thank you very much!

While you're at it, could you also take a look at these other open PR's?

jooname added a commit that referenced this pull request Jun 4, 2025
…from #127 are pretty simple to include. Included also PHP 7.0 support back, since the PHP 8.4 compatibility changes from #121 were possible to achieve another way. Updated Github workflow to include more PHP versions. Adjusted loophp/phposinfo package compatibility adjustment from #127 to be autoloader based, since the change from pull request didn't work with the testsuite. Managed to also adjust the testsuite to take into account the autoloader customisation. Fixed also issues in the testsuite where all package names were prefixed with __ even though only a handful of packages were supposed to be affected. Adjusted the testsuite to understand Composer 1 and 2 outputs again, but flipped the intention of .output to be based on latest Composer rather than 1 like earlier. Updated dependency whitelists based on the older versions, looks like symfony/console has lots of incompatibilities that have been suppressed with function_exists and autoloader workarounds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PHP 8.4 deprecation notices: "Implicitly marking parameter $xxx as nullable is deprecated"

4 participants