Fix retries on successful messages#17
Open
brucruz wants to merge 3 commits intovalamistudio:masterfrom
Open
Conversation
brucruz
commented
May 9, 2025
brucruz
commented
- Moved @Retry decorator to a separate fetch_with_response() function
- Prevented retries from duplicating bot replies on failure
- Improved error handling for JSON parsing and Wit.AI response
- Moved @Retry decorator to a separate fetch_with_response() function - Prevented retries from duplicating bot replies on failure - Improved error handling for JSON parsing and Wit.AI response
- Moved @Retry decorator to a separate fetch_with_response() function - Prevented retries from duplicating bot replies on failure - Improved error handling for JSON parsing and Wit.AI response
Logerfo
requested changes
May 9, 2025
Member
Logerfo
left a comment
Logerfo
left a comment
There was a problem hiding this comment.
These changes don't fix the duplication issue, as it's probably being caused by an architecture flaw. Regardless of that, I think they make the code a little better, so I'm willing to accept it, as long as we keep the comments.
Comment on lines
-22
to
-23
| #?v=20221114 | ||
| #&context=%7B%22locale%22%3A%22pt_BR%22%7D |
Member
There was a problem hiding this comment.
I appreciate having those comments, although the code is currently not being used, it provides useful context in case we need to provide those parameters to the vendor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.