Fix (formatVideo): guard against undefined title and improve artist/title extraction#33
Open
1ly4s0 wants to merge 1 commit intovalerebron:masterfrom
Open
Fix (formatVideo): guard against undefined title and improve artist/title extraction#331ly4s0 wants to merge 1 commit intovalerebron:masterfrom
1ly4s0 wants to merge 1 commit intovalerebron:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the
formatVideohelper more robust by ensuringvideo.titleis always treated as a string and by using a safer splitting and regex strategy to extract artist and title. Previously, callingvideo.title.split('-')would throw whenvideo.titlewasundefined, and the simplematch(/([^,]*)-(.*)/)could fail or produce unintended results.Changes include:
Ensure
titleStris always a string.video.titleto''if it isn’t a string, thentrim().video.original_title.Safer split logic.
titleStr.split('-')only to detect presence of a hyphen without risking aTypeError.Improved regex extraction.
/^([^–-]+)[–-](.+)$/to handle both ASCII-and en-dash–, capturing exactly two groups: artist and title.Fallback behavior.
artist = ''and leavetitle = titleStr.Minor cleanup:
console.error('formatVideo failed:', err)for better debugging.Why:
TypeErrorwhenvideo.titleisundefinedor not a string.Testing:
video.titleasundefinedor non-string.artist,title, andpublishedAt.