Bump rocksdb to 0.24#337
Merged
valeriansaliou merged 1 commit intovaleriansaliou:masterfrom Feb 17, 2026
Merged
Conversation
Fixes build on NixOS after GCC 15 and librocksdb upgrades. * librocksdb 10.7.5 removed rocksdb_options_set_access_hint_on_compaction_start from the API * rocksdb-rs 0.24 adds support for GCC 15 and updated API bindings See failing build: https://hydra.nixos.org/build/317945528
Contributor
Author
|
Fixes failing build after librocksdb upgrade (fixed by rust-rocksdb/rust-rocksdb#872): error[E0425]: cannot find function `rocksdb_options_set_access_hint_on_compaction_start` in crate `ffi`
--> /build/sonic-server-1.4.9-unstable-vendor/rocksdb-0.22.0/src/db_options.rs:2859:18
|
2859 | ffi::rocksdb_options_set_access_hint_on_compaction_start(self.inner, pattern as c_int);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: a function with a similar name exists: `rocksdb_options_set_disable_auto_compactions`
|
::: /build/source/target/x86_64-unknown-linux-gnu/release/build/librocksdb-sys-7d28b4e2984a2409/out/bindings.rs:3812:5
|
3812 | / pub fn rocksdb_options_set_disable_auto_compactions(
3813 | | arg1: *mut rocksdb_options_t,
3814 | | arg2: libc::c_int,
3815 | | );
| |______- similarly named function `rocksdb_options_set_disable_auto_compactions` defined hereand failing build after GCC 15 upgrade (fixed by rust-rocksdb/rust-rocksdb#1007): warning: librocksdb-sys@0.11.0+8.1.1: In file included from rocksdb/db/blob/blob_file_meta.cc:6:
warning: librocksdb-sys@0.11.0+8.1.1: rocksdb/db/blob/blob_file_meta.h:28:7: error: 'uint64_t' has not been declared
warning: librocksdb-sys@0.11.0+8.1.1: 28 | uint64_t blob_file_number, uint64_t total_blob_count,
warning: librocksdb-sys@0.11.0+8.1.1: | ^~~~~~~~
warning: librocksdb-sys@0.11.0+8.1.1: rocksdb/db/blob/blob_file_meta.h:15:1: note: 'uint64_t' is defined in header '<cstdint>'; this is probably fixable by adding '#include <cstdint>'
warning: librocksdb-sys@0.11.0+8.1.1: 14 | #include "rocksdb/rocksdb_namespace.h"
warning: librocksdb-sys@0.11.0+8.1.1: +++ |+#include <cstdint>
warning: librocksdb-sys@0.11.0+8.1.1: 15 |
warning: librocksdb-sys@0.11.0+8.1.1: rocksdb/db/blob/blob_file_meta.h:28:34: error: 'uint64_t' has not been declared
warning: librocksdb-sys@0.11.0+8.1.1: 28 | uint64_t blob_file_number, uint64_t total_blob_count,
warning: librocksdb-sys@0.11.0+8.1.1: | ^~~~~~~~
warning: librocksdb-sys@0.11.0+8.1.1: rocksdb/db/blob/blob_file_meta.h:28:34: note: 'uint64_t' is defined in header '<cstdint>'; this is probably fixable by adding '#include <cstdint>'
warning: librocksdb-sys@0.11.0+8.1.1: rocksdb/db/blob/blob_file_meta.h:29:7: error: 'uint64_t' has not been declared
warning: librocksdb-sys@0.11.0+8.1.1: 29 | uint64_t total_blob_bytes, std::string checksum_method,
warning: librocksdb-sys@0.11.0+8.1.1: | ^~~~~~~~ |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes build on NixOS after GCC 14 -> 15 and librocksdb upgrades.
See failing build: https://hydra.nixos.org/build/317945528