added apis for planned maintenance mode#115
Open
jasquat wants to merge 2 commits intovaleriansaliou:masterfrom
Open
added apis for planned maintenance mode#115jasquat wants to merge 2 commits intovaleriansaliou:masterfrom
jasquat wants to merge 2 commits intovaleriansaliou:masterfrom
Conversation
jasquat
changed the title
jasquat
force-pushed
the
add_apis_for_planned_maintenance
branch
from
3ac9ea6 to
d2a6959
Compare
Owner
|
Thank you, I'll review this by next week. |
|
Hi @valeriansaliou |
Owner
Hey! It's already possible via: https://github.com/valeriansaliou/vigil/blob/master/PROTOCOL.md#2%EF%B8%8F⃣-insert-a-new-announcement |
UiP9AV6Y
reviewed
Oct 12, 2023
| .service( | ||
| web::resource("/probe/stop_planned_maintenance/{probe_id}") | ||
| .wrap(middleware_auth.clone()) | ||
| .guard(guard::Post()) |
There was a problem hiding this comment.
should that not be a Delete like with the reporter flush endpoint? also the resource endpoint should probably be /maintenance/{probe_id}, similar to the reporter endpoint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our context, we use probes to indicate environments. These environments are disposable. So when we want to delete and recreate one, we wanted a way to tell vigil that things were not going to be working as usual with the environment during this maintenance period. Specifically, we did not want to receive down and recovery alerts in slack. This pull request adds two apis that allow people to disable and enable notifications for downed probes.
We also added timestamps to logs in src/config/logger.rs. Let us know if this is undesired but it has been really useful for us.