added "block" prop toggle for the inline display type#42
added "block" prop toggle for the inline display type#42JanLunge wants to merge 1 commit intovalgeirb:mainfrom
Conversation
|
Can we get this merged in please? Really need this lol |
|
Can you give me an example of what problem this is solving? |
|
The inline-block prevents us from having full-width wrapper elements. Im currently using it to wrap around input fields to display a possible error message, but with the inline-block the input fields cannot be full-width |
|
It's better not to force any specific display style. Why not let the user do it? Also it will make easier to redefine styles. |
Yeah these are good points. It's a fine line though, if I remove the inline style for example, the Popper won't be positioned correctly for most use cases and I don't want to make it frustrating for users. This PR might be the solution. |
|
One solution that might be more flexible is allowing the user to define a class name as a prop and attaching that to the div. Then the user can override the classes and styles as they need. Primevue does this on elements that it inserts, typically allowing either a class name or inline styles to be defined as a prop. |
|
base popper appears to use translate3d to handle the offset distance and skid? Why not just rely on the native popper js implementation of these? |
I needed to warp a full width element so to do that I need to be able to toggle the inline-block class on the wrapper,
this is done with the prop
blockhere.might be related to #6 (comment)