exposed popper update method to allow parents to call it#91
Open
LukePa wants to merge 1 commit intovalgeirb:mainfrom
Open
exposed popper update method to allow parents to call it#91LukePa wants to merge 1 commit intovalgeirb:mainfrom
LukePa wants to merge 1 commit intovalgeirb:mainfrom
Conversation
|
I really need this one! |
|
Need this one too :) |
|
Any chance this gets merged in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Popper content that resizes itself while the popper is open currently can lead to positioning issues as the popper can't update itself.
The example I'm currently working with is a popper menu that allows searching for users, expanding the height and width of the popper.
Exposing the update method of the underlying popper instance would allow parent components to force the position to update. This would hopefully increase the possible use cases for the library