Remove jquery-ui-bundle and use vanilla js instead#243
Merged
Conversation
Merged
Collaborator
Author
|
ping @nilsnolde @chrstnbwnkl, it could be nice if we can merge this and #244 |
Member
|
Definitely, I'll build and run it later today. I don't have much to add on logical review, I'll just do some UX playing around. |
nilsnolde
approved these changes
Sep 17, 2025
Member
nilsnolde
left a comment
There was a problem hiding this comment.
Thanks for doing this! The only tiny little thing I found was: if the left panel is closed while the height graph is open that graph closes, where on master it doesn't. On master it tries to (not very successfully) resize instead.
Anyways, not in any way a blocker IMO.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #181
🛠️ Fixes Issue
While we want migrate the project to vite and modern development stack, one of the blocker was jQuery. To handle jQuery in vite, we have to use plugins like
rollup-plugin-inject. But why would we need what when we can solve the problem at its root?This PR closes #181 and removes the jQuery.
👨💻 Changes proposed
jquery-ui-bundleandjQueryparserOptionsofeslintsince we are using modern features of ecmascript.📄 Note to reviewers
"ecmaVersion": 2022because we are using**?.**syntax in the project.