Skip to content

Remove jquery-ui-bundle and use vanilla js instead#243

Merged
nilsnolde merged 1 commit intomasterfrom
issue-181-remove-jquery
Sep 17, 2025
Merged

Remove jquery-ui-bundle and use vanilla js instead#243
nilsnolde merged 1 commit intomasterfrom
issue-181-remove-jquery

Conversation

@mustaphaturhan
Copy link
Collaborator

Closes #181

🛠️ Fixes Issue

While we want migrate the project to vite and modern development stack, one of the blocker was jQuery. To handle jQuery in vite, we have to use plugins like rollup-plugin-inject. But why would we need what when we can solve the problem at its root?

This PR closes #181 and removes the jQuery.

👨‍💻 Changes proposed

  • Removes jquery-ui-bundle and jQuery
  • Updates the parserOptions of eslint since we are using modern features of ecmascript.

📄 Note to reviewers

  • I updated to "ecmaVersion": 2022 because we are using **?.** syntax in the project.

@mustaphaturhan
Copy link
Collaborator Author

ping @nilsnolde @chrstnbwnkl, it could be nice if we can merge this and #244

@nilsnolde
Copy link
Member

Definitely, I'll build and run it later today. I don't have much to add on logical review, I'll just do some UX playing around.

Copy link
Member

@nilsnolde nilsnolde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! The only tiny little thing I found was: if the left panel is closed while the height graph is open that graph closes, where on master it doesn't. On master it tries to (not very successfully) resize instead.

Anyways, not in any way a blocker IMO.

@nilsnolde nilsnolde merged commit ccc9740 into master Sep 17, 2025
2 of 3 checks passed
@nilsnolde nilsnolde deleted the issue-181-remove-jquery branch September 17, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

jQuery is not defined

2 participants